Upgrade to PowerShell 7#16075
Conversation
…mands to Windows PowerShell
Performance Test ResultsBranch: ✅ Passed161 scenario(s) across 28 suite(s) — no regressionsSectionList
FlatList
TouchableOpacity
ScrollView
TouchableHighlight
Pressable
Modal
Image
ActivityIndicator
Switch
Button
TextInput
View
Text
SectionList.native-perf-test.ts
FlatList.native-perf-test.ts
TouchableHighlight.native-perf-test.ts
TouchableOpacity.native-perf-test.ts
Pressable.native-perf-test.ts
ScrollView.native-perf-test.ts
ActivityIndicator.native-perf-test.ts
TextInput.native-perf-test.ts
Switch.native-perf-test.ts
Button.native-perf-test.ts
Modal.native-perf-test.ts
Image.native-perf-test.ts
View.native-perf-test.ts
Text.native-perf-test.ts
|
| } | ||
| } catch {} | ||
|
|
||
| return `${process.env.SystemRoot}\\System32\\WindowsPowerShell\\v1.0\\powershell.exe`; |
There was a problem hiding this comment.
You are changing the compatiblity matrix here. The old powershell was assumed to be part of windows and is fully backwrads compatible... Now you make the repo control the version via a specific version in nuget....
Since the feature set is massively different I can see us starting depend on 7.x features...
So then if it can't find it we'll get weird errors that can be confusing...
Especailly since above we search for it globally installed...
My preference is if NOT in global packages error out HARD and tell folks to run nuget to get the package...
That way we are guaranteed to have all engineers have the same version...
If you do a path fallback. Please add a check for the version to make sure the user (or CI) has globally installed the same version... And provide instructions how to upgrade if not there....
Just never fall back to v4...
Description
Type of Change
Why
PowerShell 7 offers multiple performance improvements over Windows PowerShell (5.1).
🔍 PowerShell 7.x vs Windows PowerShell 5.1 — Performance & Security
ForEach-Object -Parallel) 【3-bc07e3】See https://techieramesh.com/devops/windows-automation/ps-5-1-vs-7-5-comparison/
What
vnext/dotnet-tools.json). (NuGet package to reduce set up footprint on the developer's machine).powershell.exewithpwsh.exe(except CMD and MSBuild files, for now).@react-native-windows/find-dotnet-toolsto provide a common set of functions to determine PowerShell's (and potentially any other DotNet tool) location.Testing
CI checks pass
Microsoft Reviewers: Open in CodeFlow